gnss: sirf: fix error return code in sirf_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 7 May 2020 09:42:52 +0000 (09:42 +0000)
committerJohan Hovold <johan@kernel.org>
Wed, 13 May 2020 14:42:07 +0000 (16:42 +0200)
commit43d7ce70ae43dd8523754b17f567417e0e75dbce
tree16bd8bcb2701a48f209a43d86842270605422099
parent2ef96a5bb12be62ef75b5828c0aab838ebb29cb8
gnss: sirf: fix error return code in sirf_probe()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

This avoids a use-after-free in case the driver is later unbound.

Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
[ johan: amend commit message; mention potential use-after-free ]
Cc: stable <stable@vger.kernel.org> # 4.19
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/gnss/sirf.c