vdpa/mlx5: Fix mlx5_vdpa_get_config() endianness on big-endian machines
authorKonstantin Shkolnyy <kshk@linux.ibm.com>
Tue, 4 Feb 2025 17:31:27 +0000 (11:31 -0600)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 25 Feb 2025 12:10:45 +0000 (07:10 -0500)
commit439252e167ac45a5d46f573aac1da7d8f3e051ad
treee37aa1db7cbc16a7a482ce1c9ee72d37d714b46b
parent5dd639a1646ef5fe8f4bf270fad47c5c3755b9b6
vdpa/mlx5: Fix mlx5_vdpa_get_config() endianness on big-endian machines

mlx5_vdpa_dev_add() doesn’t initialize mvdev->actual_features. It’s
initialized later by mlx5_vdpa_set_driver_features(). However,
mlx5_vdpa_get_config() depends on the VIRTIO_F_VERSION_1 flag in
actual_features, to return data with correct endianness. When it’s called
before mlx5_vdpa_set_driver_features(), the data are incorrectly returned
as big-endian on big-endian machines, while QEMU then interprets them as
little-endian.

The fix is to initialize this VIRTIO_F_VERSION_1 as early as possible,
especially considering that mlx5_vdpa_dev_add() insists on this flag to
always be set anyway.

Signed-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com>
Message-Id: <20250204173127.166673-1-kshk@linux.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Acked-by: Jason Wang <jasowang@redhat.com>
drivers/vdpa/mlx5/net/mlx5_vnet.c