media: s5p-mfc: Fix memdev DMA configuration
authorRobin Murphy <robin.murphy@arm.com>
Mon, 14 Jan 2019 15:14:14 +0000 (15:14 +0000)
committerRob Herring <robh@kernel.org>
Tue, 22 Jan 2019 00:49:32 +0000 (18:49 -0600)
commit42e45a9449f1376d4decd751612a48f6db1f6e37
treef9bd1596bb595d95221e764595bd2a252655dd53
parentbf72e42d400ace273931151b3a9bf1f8b846ec45
media: s5p-mfc: Fix memdev DMA configuration

Having of_reserved_mem_device_init() forcibly reconfigure DMA for all
callers, potentially overriding the work done by a bus-specific
.dma_configure method earlier, is at best a bad idea and at worst
actively harmful. If drivers really need virtual devices to own
dma-coherent memory, they should explicitly configure those devices
based on the appropriate firmware node as they create them.

It looks like the only driver not passing in a proper OF platform device
is s5p-mfc, so move the rogue of_dma_configure() call into that driver
where it logically belongs.

Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/media/platform/s5p-mfc/s5p_mfc.c
drivers/of/of_reserved_mem.c