media: vsp1: Remove unbalanced .s_stream(0) calls
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 24 Oct 2023 14:18:17 +0000 (17:18 +0300)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 13 Nov 2023 01:40:13 +0000 (03:40 +0200)
commit42d62b7e47d58273c64fc1540e5d81ccfdb60f77
tree2c0dd51d44f82897167c0aa98888c21ba46bfddc
parentb85ea95d086471afb4ad062012a4d73cd328fa86
media: vsp1: Remove unbalanced .s_stream(0) calls

The VSP1 driver uses the subdev .s_stream() operation to stop WPF
instances, without a corresponding call to start them. The V4L2 subdev
core started warning about unbalanced .s_stream() calls in commit
009905ec5043 ("media: v4l2-subdev: Document and enforce .s_stream()
requirements"), causing a regression with this driver.

Fix the problem by replacing the .s_stream() operation with an explicit
function call for WPF instances. This allows sharing an additional data
structure between RPF and WPF instances.

Fixes: 009905ec5043 ("media: v4l2-subdev: Document and enforce .s_stream() requirements")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://lore.kernel.org/linux-media/2221395-6a9b-9527-d697-e76aebc6af@linux-m68k.org/
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/media/platform/renesas/vsp1/vsp1_pipe.c
drivers/media/platform/renesas/vsp1/vsp1_rpf.c
drivers/media/platform/renesas/vsp1/vsp1_rwpf.c
drivers/media/platform/renesas/vsp1/vsp1_rwpf.h
drivers/media/platform/renesas/vsp1/vsp1_wpf.c