scsi: fcoe: Fix transport not deattached when fcoe_if_init() fails
authorChen Zhongjin <chenzhongjin@huawei.com>
Tue, 15 Nov 2022 09:24:42 +0000 (17:24 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 26 Nov 2022 00:14:27 +0000 (00:14 +0000)
commit4155658cee394b22b24c6d64e49247bf26d95b92
treeecf452c3db2710fe8ee1bf1ffda32150708f3cb0
parent42c5907728867df91045f532a38682e0ec7a955b
scsi: fcoe: Fix transport not deattached when fcoe_if_init() fails

fcoe_init() calls fcoe_transport_attach(&fcoe_sw_transport), but when
fcoe_if_init() fails, &fcoe_sw_transport is not detached and leaves freed
&fcoe_sw_transport on fcoe_transports list. This causes panic when
reinserting module.

 BUG: unable to handle page fault for address: fffffbfff82e2213
 RIP: 0010:fcoe_transport_attach+0xe1/0x230 [libfcoe]
 Call Trace:
  <TASK>
  do_one_initcall+0xd0/0x4e0
  load_module+0x5eee/0x7210
  ...

Fixes: 78a582463c1e ("[SCSI] fcoe: convert fcoe.ko to become an fcoe transport provider driver")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Link: https://lore.kernel.org/r/20221115092442.133088-1-chenzhongjin@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fcoe/fcoe.c