don't reference freed command in scsi_prep_return
authorChristoph Hellwig <hch@lst.de>
Tue, 15 Apr 2014 10:24:56 +0000 (12:24 +0200)
committerJens Axboe <axboe@fb.com>
Thu, 2 Apr 2015 18:12:26 +0000 (12:12 -0600)
commit4115d659efd7fdcd9c244df20715ed35a7c7a5e6
tree0dfbd51d7ab14e09829804adf9c5fc5d7c4bcff3
parent70fa269fa849e7c6042f6f9399df3748846bb658
don't reference freed command in scsi_prep_return

Patch

commit 0479633686d370303e3430256ace4bd5f7f138dc
Author: Christoph Hellwig <hch@infradead.org>
Date:   Thu Feb 20 14:20:55 2014 -0800

    [SCSI] do not manipulate device reference counts in scsi_get/put_command

Introduced a use after free:I in the kill case of scsi_prep_return we have to
release our device reference, but we do this trying to reference the just
freed command.  Use the local sdev pointer instead.

Fixes: 0479633686d370303e3430256ace4bd5f7f138dc
Reported-by: Joe Lawrence <joe.lawrence@stratus.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/scsi_lib.c