watchdog: iTCO_wdt: Report error if timeout configuration fails
authorZiyan Fu <fuzy5@lenovo.com>
Fri, 4 Jul 2025 07:35:18 +0000 (15:35 +0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Wed, 16 Jul 2025 16:05:02 +0000 (18:05 +0200)
commit40efc43eb7ffb5a4e2f998c13b8cfb555e671b92
treee57204d7e1a08831c0fa23f0a1239467174a3897
parent3b3643e1cd6f276810640ee04e41c04e7a753c0f
watchdog: iTCO_wdt: Report error if timeout configuration fails

The driver probes with the invalid timeout value when
'iTCO_wdt_set_timeout()' fails, as its return value is not checked. In
this case, when executing "wdctl", we may get:

Device:        /dev/watchdog0
Timeout:       30 seconds
Timeleft:      613 seconds

The timeout value is the value of "heartbeat" or "WATCHDOG_TIMEOUT", and
the timeleft value is calculated from the register value we actually read
(0xffff) by masking with 0x3ff and converting ticks to seconds (* 6 / 10).

Add error handling to return the failure code if 'iTCO_wdt_set_timeout()'
fails, ensuring the driver probe fails and prevents invalid operation.

Signed-off-by: Ziyan Fu <fuzy5@lenovo.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20250704073518.7838-1-13281011316@163.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/iTCO_wdt.c