samples: Replace strlcpy() with strscpy()
authorKees Cook <keescook@chromium.org>
Thu, 16 Nov 2023 19:15:10 +0000 (11:15 -0800)
committerKees Cook <keescook@chromium.org>
Thu, 30 Nov 2023 20:20:53 +0000 (12:20 -0800)
commit40b2519d7566266d7eafd3c5232c73a497640bca
tree9dfc5c39966ded80e08f4666cb516887b13da08e
parentcb6d2fd30dddd00499333e9475f8b11bbd84f37c
samples: Replace strlcpy() with strscpy()

strlcpy() reads the entire source buffer first. This read may exceed
the destination size limit. This is both inefficient and can lead
to linear read overflows if a source string is not NUL-terminated[1].
Additionally, it returns the size of the source string, not the
resulting size of the destination string. In an effort to remove strlcpy()
completely[2], replace strlcpy() here with strscpy().

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
Link: https://github.com/KSPP/linux/issues/89
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Valentin Schneider <vschneid@redhat.com>
Cc: "Steven Rostedt (Google)" <rostedt@goodmis.org>
Cc: Chuck Lever <chuck.lever@oracle.com>
Cc: Geliang Tang <geliang.tang@suse.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Acked-by: "Steven Rostedt (Google)" <rostedt@goodmis.org>
Link: https://lore.kernel.org/r/20231116191510.work.550-kees@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
samples/trace_events/trace-events-sample.h
samples/v4l/v4l2-pci-skeleton.c