idpf: fix idpf_vport_splitq_napi_poll()
authorEric Dumazet <edumazet@google.com>
Tue, 20 May 2025 12:40:30 +0000 (12:40 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 May 2025 03:43:15 +0000 (20:43 -0700)
commit407e0efdf8baf1672876d5948b75049860a93e59
tree058b010e82fd05997bb296b00bf3224c3ed850ca
parentd83ec0b284e8a8a666d94ca00d7e1086b2173b3e
idpf: fix idpf_vport_splitq_napi_poll()

idpf_vport_splitq_napi_poll() can incorrectly return @budget
after napi_complete_done() has been called.

This violates NAPI rules, because after napi_complete_done(),
current thread lost napi ownership.

Move the test against POLL_MODE before the napi_complete_done().

Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support")
Reported-by: Peter Newman <peternewman@google.com>
Closes: https://lore.kernel.org/netdev/20250520121908.1805732-1-edumazet@google.com/T/#u
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Joshua Hay <joshua.a.hay@intel.com>
Cc: Alan Brady <alan.brady@intel.com>
Cc: Madhu Chittim <madhu.chittim@intel.com>
Cc: Phani Burra <phani.r.burra@intel.com>
Cc: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Link: https://patch.msgid.link/20250520124030.1983936-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/idpf/idpf_txrx.c