vhost-scsi: Fix check for inline_sg_cnt exceeding preallocated limit
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Sat, 28 Jun 2025 18:33:53 +0000 (11:33 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 1 Aug 2025 13:11:08 +0000 (09:11 -0400)
commit400cad513c78f9af72c5a20f3611c1f1dc71d465
treeba7f0771e276f18289bbf95498793aa7f0a585da
parent95109b46764665e3de4a118185e4f732e8e849fd
vhost-scsi: Fix check for inline_sg_cnt exceeding preallocated limit

The condition comparing ret to VHOST_SCSI_PREALLOC_SGLS was incorrect,
as ret holds the result of kstrtouint() (typically 0 on success),
not the parsed value. Update the check to use cnt, which contains the
actual user-provided value.

prevents silently accepting values exceeding the maximum inline_sg_cnt.

Fixes: bca939d5bcd0 ("vhost-scsi: Dynamically allocate scatterlists")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20250628183405.3979538-1-alok.a.tiwari@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
drivers/vhost/scsi.c