drm/amd/display: Add NULL pointer checks in dm_force_atomic_commit()
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Thu, 17 Apr 2025 19:27:19 +0000 (00:57 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 22 Apr 2025 12:51:46 +0000 (08:51 -0400)
commit3f397cd203f247879c2f1a061e90d4c8d23655de
tree4781cfb4e52901be48c1cb5d7c50bc268fa14e99
parent42a66677805d03df9e2600fab82d0cbe855500e1
drm/amd/display: Add NULL pointer checks in dm_force_atomic_commit()

This commit updates the dm_force_atomic_commit function to replace the
usage of PTR_ERR_OR_ZERO with IS_ERR for checking error states after
retrieving the Connector (drm_atomic_get_connector_state), CRTC
(drm_atomic_get_crtc_state), and Plane (drm_atomic_get_plane_state)
states.

The function utilized PTR_ERR_OR_ZERO for error checking. However, this
approach is inappropriate in this context because the respective
functions do not return NULL; they return pointers that encode errors.

This change ensures that error pointers are properly checked using
IS_ERR before attempting to dereference.

Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Cc: Tom Chung <chiahsuan.chung@amd.com>
Cc: Roman Li <roman.li@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c