iio: buffer: make sure O_NONBLOCK is respected
authorNuno Sá <nuno.sa@analog.com>
Thu, 16 Feb 2023 10:14:51 +0000 (11:14 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 18 Feb 2023 14:07:58 +0000 (14:07 +0000)
commit3da1814184582ed0faf039275a3f02e6f69944ee
tree11b508faf54a6b4451a383c1aaee042f2ae9913d
parentb5184a26a28fac1d708b0bfeeb958a9260c2924c
iio: buffer: make sure O_NONBLOCK is respected

For output buffers, there's no guarantee that the buffer won't be full
in the first iteration of the loop in which case we would block
independently of userspace passing O_NONBLOCK or not. Fix it by always
checking the flag before going to sleep.

While at it (and as it's a bit related), refactored the loop so that the
stop condition is 'written != n', i.e, run the loop until all data has
been copied into the IIO buffers. This makes the code a bit simpler.

Fixes: 9eeee3b0bf190 ("iio: Add output buffer support")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20230216101452.591805-3-nuno.sa@analog.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/industrialio-buffer.c