netfilter: xt_physdev: Fix spurious error message in physdev_mt_check
authorTodd Seidelmann <tseidelmann@linode.com>
Wed, 21 Aug 2019 15:47:53 +0000 (11:47 -0400)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 27 Aug 2019 10:58:28 +0000 (12:58 +0200)
commit3cf2f450fff304be9cf4868bf0df17f253bc5b1c
treea6ff94f53bf8f50878a74ee19103da2d78c40e8c
parentf53a7ad189594a112167efaf17ea8d0242b5ac00
netfilter: xt_physdev: Fix spurious error message in physdev_mt_check

Simplify the check in physdev_mt_check() to emit an error message
only when passed an invalid chain (ie, NF_INET_LOCAL_OUT).
This avoids cluttering up the log with errors against valid rules.

For large/heavily modified rulesets, current behavior can quickly
overwhelm the ring buffer, because this function gets called on
every change, regardless of the rule that was changed.

Signed-off-by: Todd Seidelmann <tseidelmann@linode.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/xt_physdev.c