rbd: don't assume rbd_is_lock_owner() for exclusive mappings
authorIlya Dryomov <idryomov@gmail.com>
Tue, 23 Jul 2024 16:08:08 +0000 (18:08 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 25 Jul 2024 10:18:29 +0000 (12:18 +0200)
commit3ceccb14f5576e02b81cc8b105ab81f224bd87f6
tree6a1f2f51a0ac2adea4254265f1eedb525cb9e320
parent2237ceb71f89837ac47c5dce2aaa2c2b3a337a3c
rbd: don't assume rbd_is_lock_owner() for exclusive mappings

Expanding on the previous commit, assuming that rbd_is_lock_owner()
always returns true (i.e. that we are either in RBD_LOCK_STATE_LOCKED
or RBD_LOCK_STATE_QUIESCING) if the mapping is exclusive is wrong too.
In case ceph_cls_set_cookie() fails, the lock would be temporarily
released even if the mapping is exclusive, meaning that we can end up
even in RBD_LOCK_STATE_UNLOCKED.

IOW, exclusive mappings are really "just" about disabling automatic
lock transitions (as documented in the man page), not about grabbing
the lock and holding on to it whatever it takes.

Cc: stable@vger.kernel.org
Fixes: 637cd060537d ("rbd: new exclusive lock wait/wake code")
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
drivers/block/rbd.c