net: xfrm: fix shift-out-of-bounds in xfrm_get_default
authorPavel Skripkin <paskripkin@gmail.com>
Thu, 2 Sep 2021 19:04:00 +0000 (22:04 +0300)
committerSteffen Klassert <steffen.klassert@secunet.com>
Thu, 9 Sep 2021 10:12:17 +0000 (12:12 +0200)
commit3c10ffddc61f8a1a59e29a110ba70b47e679206a
tree7af23af0a5764faae0f99988c410e224cbaf44dc
parent626bf91a292e2035af5b9d9cce35c5c138dfe06d
net: xfrm: fix shift-out-of-bounds in xfrm_get_default

Syzbot hit shift-out-of-bounds in xfrm_get_default. The problem was in
missing validation check for user data.

up->dirmask comes from user-space, so we need to check if this value
is less than XFRM_USERPOLICY_DIRMASK_MAX to avoid shift-out-of-bounds bugs.

Fixes: 2d151d39073a ("xfrm: Add possibility to set the default to block if we have no policy")
Reported-and-tested-by: syzbot+b2be9dd8ca6f6c73ee2d@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_user.c