bpf: Refactor bpf_tracing_func_proto() and remove bpf_get_probe_write_proto()
authorMarco Elver <elver@google.com>
Fri, 29 Nov 2024 08:59:34 +0000 (09:59 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 2 Dec 2024 16:42:02 +0000 (08:42 -0800)
commit3bfb49d73fc281f06c0d976db898debebc8223e3
treeebe7871415c2999f5e51f7cad9a2141d4fe0d391
parentb28573ebfabeca24757e121566bd143a68097030
bpf: Refactor bpf_tracing_func_proto() and remove bpf_get_probe_write_proto()

With bpf_get_probe_write_proto() no longer printing a message, we can
avoid it being a special case with its own permission check.

Refactor bpf_tracing_func_proto() similar to bpf_base_func_proto() to
have a section conditional on bpf_token_capable(CAP_SYS_ADMIN), where
the proto for bpf_probe_write_user() is returned. Finally, remove the
unnecessary bpf_get_probe_write_proto().

This simplifies the code, and adding additional CAP_SYS_ADMIN-only
helpers in future avoids duplicating the same CAP_SYS_ADMIN check.

Suggested-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Marco Elver <elver@google.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/r/20241129090040.2690691-2-elver@google.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/trace/bpf_trace.c