net: fec: avoid lock evasion when reading pps_enable
authorWei Fang <wei.fang@nxp.com>
Tue, 21 May 2024 02:38:00 +0000 (10:38 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 23 May 2024 09:15:54 +0000 (11:15 +0200)
commit3b1c92f8e5371700fada307cc8fd2c51fa7bc8c1
tree30d41b515ce3c8ab78a3b9a29dfa2c5dd1d2807a
parentb35b1c0b4e166a427395deaf61e3140495dfcb89
net: fec: avoid lock evasion when reading pps_enable

The assignment of pps_enable is protected by tmreg_lock, but the read
operation of pps_enable is not. So the Coverity tool reports a lock
evasion warning which may cause data race to occur when running in a
multithread environment. Although this issue is almost impossible to
occur, we'd better fix it, at least it seems more logically reasonable,
and it also prevents Coverity from continuing to issue warnings.

Fixes: 278d24047891 ("net: fec: ptp: Enable PPS output based on ptp clock")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
Link: https://lore.kernel.org/r/20240521023800.17102-1-wei.fang@nxp.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/freescale/fec_ptp.c