riscv: KGDB: Do not inline arch_kgdb_breakpoint()
authorWangYuli <wangyuli@uniontech.com>
Fri, 11 Apr 2025 07:32:21 +0000 (15:32 +0800)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 16 Apr 2025 14:29:33 +0000 (07:29 -0700)
commit3af4bec9c1db3f003be4d5ae09b6a737e4be1612
treefe3bb318df4fd462fd90b3afab4ab326664d879d
parent0af2f6be1b4281385b618cb86ad946eded089ac8
riscv: KGDB: Do not inline arch_kgdb_breakpoint()

The arch_kgdb_breakpoint() function defines the kgdb_compiled_break
symbol using inline assembly.

There's a potential issue where the compiler might inline
arch_kgdb_breakpoint(), which would then define the kgdb_compiled_break
symbol multiple times, leading to fail to link vmlinux.o.

This isn't merely a potential compilation problem. The intent here
is to determine the global symbol address of kgdb_compiled_break,
and if this function is inlined multiple times, it would logically
be a grave error.

Link: https://lore.kernel.org/all/4b4187c1-77e5-44b7-885f-d6826723dd9a@sifive.com/
Link: https://lore.kernel.org/all/5b0adf9b-2b22-43fe-ab74-68df94115b9a@ghiti.fr/
Link: https://lore.kernel.org/all/23693e7f-4fff-40f3-a437-e06d827278a5@ghiti.fr/
Fixes: fe89bd2be866 ("riscv: Add KGDB support")
Co-developed-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Link: https://lore.kernel.org/r/F22359AFB6FF9FD8+20250411073222.56820-1-wangyuli@uniontech.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/include/asm/kgdb.h
arch/riscv/kernel/kgdb.c