selftests/net/ipsec: Fix Null pointer dereference in rtattr_pack()
authorLiu Ye <liuye@kylinos.cn>
Thu, 16 Jan 2025 01:30:37 +0000 (09:30 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 20 Jan 2025 19:25:25 +0000 (11:25 -0800)
commit3a0b7fa095212b51ed63892540c4f249991a2d74
tree1da6283619764371da1b599b7f37889e29574280
parent64ff63aeefb03139ae27454bd4208244579ae88e
selftests/net/ipsec: Fix Null pointer dereference in rtattr_pack()

Address Null pointer dereference / undefined behavior in rtattr_pack
(note that size is 0 in the bad case).

Flagged by cppcheck as:
    tools/testing/selftests/net/ipsec.c:230:25: warning: Possible null pointer
    dereference: payload [nullPointer]
    memcpy(RTA_DATA(attr), payload, size);
                           ^
    tools/testing/selftests/net/ipsec.c:1618:54: note: Calling function 'rtattr_pack',
    4th argument 'NULL' value is 0
    if (rtattr_pack(&req.nh, sizeof(req), XFRMA_IF_ID, NULL, 0)) {
                                                       ^
    tools/testing/selftests/net/ipsec.c:230:25: note: Null pointer dereference
    memcpy(RTA_DATA(attr), payload, size);
                           ^
Signed-off-by: Liu Ye <liuye@kylinos.cn>
Link: https://patch.msgid.link/20250116013037.29470-1-liuye@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/ipsec.c