wifi: wilc1000: fix ies_len type in connect path
authorJozef Hopko <jozef.hopko@altana.com>
Mon, 1 Jul 2024 16:23:20 +0000 (18:23 +0200)
committerKalle Valo <kvalo@kernel.org>
Wed, 3 Jul 2024 13:49:53 +0000 (16:49 +0300)
commit39ab8fff623053a50951b659e5f6b72343d7d78c
treef98ddb428e8f8b1863d8c4b5837fb43fe6fd219f
parent816c6bec09ed5b90a58a1e12d5a606c5b6e23f47
wifi: wilc1000: fix ies_len type in connect path

Commit 205c50306acf ("wifi: wilc1000: fix RCU usage in connect path")
made sure that the IEs data was manipulated under the relevant RCU section.
Unfortunately, while doing so, the commit brought a faulty implicit cast
from int to u8 on the ies_len variable, making the parsing fail to be
performed correctly if the IEs block is larger than 255 bytes. This failure
can be observed with Access Points appending a lot of IEs TLVs in their
beacon frames (reproduced with a Pixel phone acting as an Access Point,
which brough 273 bytes of IE data in my testing environment).

Fix IEs parsing by removing this undesired implicit cast.

Fixes: 205c50306acf ("wifi: wilc1000: fix RCU usage in connect path")
Signed-off-by: Jozef Hopko <jozef.hopko@altana.com>
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20240701-wilc_fix_ies_data-v1-1-7486cbacf98a@bootlin.com
drivers/net/wireless/microchip/wilc1000/hif.c