smb: client: fix zero rsize error messages
authorPaulo Alcantara <pc@manguebit.com>
Mon, 12 May 2025 17:58:36 +0000 (14:58 -0300)
committerSteve French <stfrench@microsoft.com>
Thu, 15 May 2025 00:26:38 +0000 (19:26 -0500)
commit3965c23773e81c476f6de30ccc5d201c59ff9714
treef94b1ede623677d9638d64fb1be4af71caa4179a
parent1fe4a44b7fa3955bcb7b4067c07b778fe90d8ee7
smb: client: fix zero rsize error messages

cifs_prepare_read() might be called with a disconnected channel, where
TCP_Server_Info::max_read is set to zero due to reconnect, so calling
->negotiate_rize() will set @rsize to default min IO size (64KiB) and
then logging

CIFS: VFS: SMB: Zero rsize calculated, using minimum value
65536

If the reconnect happens in cifsd thread, cifs_renegotiate_iosize()
will end up being called and then @rsize set to the expected value.

Since we can't rely on the value of @server->max_read by the time we
call cifs_prepare_read(), try to ->negotiate_rize() only if
@cifs_sb->ctx->rsize is zero.

Reported-by: Steve French <stfrench@microsoft.com>
Fixes: c59f7c9661b9 ("smb: client: ensure aligned IO sizes")
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/file.c