ASoC: simple-card-utils: Make simple_util_remove() return void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 13 Oct 2023 22:19:50 +0000 (00:19 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 23 Oct 2023 12:29:45 +0000 (13:29 +0100)
commit393df6f321c757d164fa412b7eae527a8e2acb75
treeab01351779803126c5ae6730eeba05ece4e11ead
parent6b02f5a6f1853c6d5f73b000afbc177f5ee59d9e
ASoC: simple-card-utils: Make simple_util_remove() return void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code.  However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

simple_util_remove() returned zero unconditionally. Make it return void
instead and convert all users to struct platform_device::remove_new().

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20231013221945.1489203-13-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/simple_card_utils.h
sound/soc/generic/audio-graph-card.c
sound/soc/generic/audio-graph-card2-custom-sample.c
sound/soc/generic/audio-graph-card2.c
sound/soc/generic/simple-card-utils.c
sound/soc/generic/simple-card.c
sound/soc/tegra/tegra_audio_graph_card.c