PCI: aardvark: Fix a leaked reference by adding missing of_node_put()
authorWen Yang <wen.yang99@zte.com.cn>
Wed, 27 Feb 2019 04:40:40 +0000 (12:40 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 1 Apr 2019 09:42:58 +0000 (10:42 +0100)
commit3842f5166bf1ef286fe7a39f262b5c9581308366
treef5a2b86961ea908f800811426d148eb61e1a3bd2
parent69adea738eb2be70b4753dbb60eb1de9abbfb4dc
PCI: aardvark: Fix a leaked reference by adding missing of_node_put()

The call to of_get_next_child() returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

irq_domain_add_linear() also calls of_node_get() to increase refcount,
so irq_domain will not be affected when it is released.

Detected by coccinelle with the following warnings:
  ./drivers/pci/controller/pci-aardvark.c:826:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 798, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
drivers/pci/controller/pci-aardvark.c