xdp: check prog type before updating BPF link
authorToke Høiland-Jørgensen <toke@redhat.com>
Fri, 7 Jan 2022 22:11:13 +0000 (23:11 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 11 Jan 2022 17:44:06 +0000 (09:44 -0800)
commit382778edc8262b7535f00523e9eb22edba1b9816
tree5c20588a75ee236ddb87ff426cf198c11cf37b9f
parent1e9d74660d4df625b0889e77018f9e94727ceacd
xdp: check prog type before updating BPF link

The bpf_xdp_link_update() function didn't check the program type before
updating the program, which made it possible to install any program type as
an XDP program, which is obviously not good. Syzbot managed to trigger this
by swapping in an LWT program on the XDP hook which would crash in a helper
call.

Fix this by adding a check and bailing out if the types don't match.

Fixes: 026a4c28e1db ("bpf, xdp: Implement LINK_UPDATE for BPF XDP link")
Reported-by: syzbot+983941aa85af6ded1fd9@syzkaller.appspotmail.com
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Link: https://lore.kernel.org/r/20220107221115.326171-1-toke@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
net/core/dev.c