firmware: qcom_scm: Fix error retval in __qcom_scm_is_call_available()
authorGuru Das Srinagesh <quic_gurus@quicinc.com>
Mon, 11 Oct 2021 20:00:14 +0000 (13:00 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Sun, 24 Oct 2021 03:12:18 +0000 (22:12 -0500)
commit38212b2a8a6fc4c3a6fa99d7445b833bedc9a67c
treee4ab56ce45dd6bc1542cfdcab84d476773f0d779
parent85f755083b23b1ee59c96df80f148e6203bb078f
firmware: qcom_scm: Fix error retval in __qcom_scm_is_call_available()

Since __qcom_scm_is_call_available() returns bool, have it return false
instead of -EINVAL if an invalid SMC convention is detected.

This fixes the Smatch static checker warning:

drivers/firmware/qcom_scm.c:255 __qcom_scm_is_call_available()
warn: signedness bug returning '(-22)'

Fixes: 9d11af8b06a8 ("firmware: qcom_scm: Make __qcom_scm_is_call_available() return bool")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/1633982414-28347-1-git-send-email-quic_gurus@quicinc.com
drivers/firmware/qcom_scm.c