net: mctp: take ownership of skb in mctp_local_output
authorJeremy Kerr <jk@codeconstruct.com.au>
Tue, 20 Feb 2024 08:10:53 +0000 (16:10 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 23 Feb 2024 03:21:11 +0000 (19:21 -0800)
commit3773d65ae5154ed7df404b050fd7387a36ab5ef3
treee88b1897f90f38182da186945678e20f322c12a3
parente872469c38b9283ef9de5e43d49286f9533ad848
net: mctp: take ownership of skb in mctp_local_output

Currently, mctp_local_output only takes ownership of skb on success, and
we may leak an skb if mctp_local_output fails in specific states; the
skb ownership isn't transferred until the actual output routing occurs.

Instead, make mctp_local_output free the skb on all error paths up to
the route action, so it always consumes the passed skb.

Fixes: 833ef3b91de6 ("mctp: Populate socket implementation")
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240220081053.1439104-1-jk@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/mctp.h
net/mctp/route.c