dm raid: Remove unnecessary negation of a shift in raid10_format_to_md_layout
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 24 Oct 2019 20:28:03 +0000 (13:28 -0700)
committerMike Snitzer <snitzer@redhat.com>
Thu, 7 Nov 2019 16:59:38 +0000 (11:59 -0500)
commit35ad035b8398c634d888324a299ec50a84cbc6cc
tree81112c3baed20ffe14bbac05a34da9b19b3f2477
parente7fad909b68aa37470d9f2d2731b5bec355ee5d6
dm raid: Remove unnecessary negation of a shift in raid10_format_to_md_layout

When building with Clang + -Wtautological-constant-compare:

 drivers/md/dm-raid.c:619:8: warning: converting the result of '<<' to a
 boolean always evaluates to true [-Wtautological-constant-compare]
                 r = !RAID10_OFFSET;
                      ^
 drivers/md/dm-raid.c:517:28: note: expanded from macro 'RAID10_OFFSET'
 #define RAID10_OFFSET                   (1 << 16) /* stripes with data
 copies area adjacent on devices */
                                           ^
 1 warning generated.

Negating a non-zero number will always make it zero, which is the
default value of r in this function so this statement is unnecessary;
remove it so that clang no longer warns.

Link: https://github.com/ClangBuiltLinux/linux/issues/753
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-raid.c