ethtool: reduce stack usage with clang
authorArnd Bergmann <arnd@arndb.de>
Thu, 7 Mar 2019 15:58:35 +0000 (16:58 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Mar 2019 17:45:21 +0000 (09:45 -0800)
commit3499e87ea0413ee5b2cc028f4c8ed4d424bc7f98
tree3040c3fdf1a56ea2c9bdd571d4b437688ffa8cd0
parentb89869da2db916914f6a2c7ab14183c8aef23d97
ethtool: reduce stack usage with clang

clang inlines the dev_ethtool() more aggressively than gcc does, leading
to a larger amount of used stack space:

net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function 'dev_ethtool' [-Werror,-Wframe-larger-than=]

Marking the sub-functions that require the most stack space as
noinline_for_stack gives us reasonable behavior on all compilers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c