uprobes: fix kernel info leak via "[uprobes]" vma
authorOleg Nesterov <oleg@redhat.com>
Sun, 29 Sep 2024 16:20:47 +0000 (18:20 +0200)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Sun, 29 Sep 2024 23:19:11 +0000 (08:19 +0900)
commit34820304cc2cd1804ee1f8f3504ec77813d29c8e
treea07b6e098d903343551b7f8d2e978ff2bf5efbe5
parentad46e8f95e931e113cb98253daf6d443ac244cde
uprobes: fix kernel info leak via "[uprobes]" vma

xol_add_vma() maps the uninitialized page allocated by __create_xol_area()
into userspace. On some architectures (x86) this memory is readable even
without VM_READ, VM_EXEC results in the same pgprot_t as VM_EXEC|VM_READ,
although this doesn't really matter, debugger can read this memory anyway.

Link: https://lore.kernel.org/all/20240929162047.GA12611@redhat.com/
Reported-by: Will Deacon <will@kernel.org>
Fixes: d4b3b6384f98 ("uprobes/core: Allocate XOL slots for uprobes use")
Cc: stable@vger.kernel.org
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
kernel/events/uprobes.c