char: tpm: tpm-buf: Add sanity check fallback in read helpers
authorPurva Yeshi <purvayeshi550@gmail.com>
Thu, 10 Apr 2025 10:34:42 +0000 (16:04 +0530)
committerJarkko Sakkinen <jarkko@kernel.org>
Thu, 15 May 2025 01:47:14 +0000 (04:47 +0300)
commit32d495b384a2db7d23c2295e03e6b6edb1c0db8d
tree637b459e20b8457cd5c7f9ba193eda95359c8a07
parent539fbab37881e32ba6a708a100de6db19e1e7e7d
char: tpm: tpm-buf: Add sanity check fallback in read helpers

Fix Smatch-detected issue:

drivers/char/tpm/tpm-buf.c:208 tpm_buf_read_u8() error:
uninitialized symbol 'value'.
drivers/char/tpm/tpm-buf.c:225 tpm_buf_read_u16() error:
uninitialized symbol 'value'.
drivers/char/tpm/tpm-buf.c:242 tpm_buf_read_u32() error:
uninitialized symbol 'value'.

Zero-initialize the return values in tpm_buf_read_u8(), tpm_buf_read_u16(),
and tpm_buf_read_u32() to guard against uninitialized data in case of a
boundary overflow.

Add defensive initialization ensures the return values are always defined,
preventing undefined behavior if the unexpected happens.

Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm-buf.c