net: designate queue -> napi linking as "ops protected"
authorJakub Kicinski <kuba@kernel.org>
Mon, 24 Mar 2025 22:45:32 +0000 (15:45 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Mar 2025 17:06:49 +0000 (10:06 -0700)
commit310ae9eb2617c62deedef8f121d7ca1ae774fa76
tree2257965b50c36fe428e5040ef6f040e675bbda35
parent0a65dcf6249b75c841b4218426b0d246a805c7e0
net: designate queue -> napi linking as "ops protected"

netdev netlink is the only reader of netdev_{,rx_}queue->napi,
and it already holds netdev->lock. Switch protection of
the writes to netdev->lock to "ops protected".

The expectation will be now that accessing queue->napi
will require netdev->lock for "ops locked" drivers, and
rtnl_lock for all other drivers.

Current "ops locked" drivers don't require any changes.
gve and netdevsim use _locked() helpers right next to
netif_queue_set_napi() so they must be holding the instance
lock. iavf doesn't call it. bnxt is a bit messy but all paths
seem locked.

Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250324224537.248800-7-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/netdevice.h
include/net/netdev_lock.h
include/net/netdev_rx_queue.h
net/core/dev.c