md/raid5: release batch_last before waiting for another stripe_head
authorDavid Jeffery <djeffery@redhat.com>
Mon, 2 Oct 2023 18:32:29 +0000 (14:32 -0400)
committerSong Liu <song@kernel.org>
Tue, 3 Oct 2023 15:53:09 +0000 (08:53 -0700)
commit2fd7b0f6d5ad655b1d947d3acdd82f687c31465e
treeb786c0716dfd48329fa5c081a34e72a86258860c
parenta578a25339aca38e23bb5af6e3fc6c2c51f0215c
md/raid5: release batch_last before waiting for another stripe_head

When raid5_get_active_stripe is called with a ctx containing a stripe_head in
its batch_last pointer, it can cause a deadlock if the task sleeps waiting on
another stripe_head to become available. The stripe_head held by batch_last
can be blocking the advancement of other stripe_heads, leading to no
stripe_heads being released so raid5_get_active_stripe waits forever.

Like with the quiesce state handling earlier in the function, batch_last
needs to be released by raid5_get_active_stripe before it waits for another
stripe_head.

Fixes: 3312e6c887fe ("md/raid5: Keep a reference to last stripe_head for batch")
Cc: stable@vger.kernel.org # v6.0+
Signed-off-by: David Jeffery <djeffery@redhat.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20231002183422.13047-1-djeffery@redhat.com
drivers/md/raid5.c