mm/damon: remove the target id concept
authorSeongJae Park <sj@kernel.org>
Wed, 16 Feb 2022 04:31:41 +0000 (15:31 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 17 Feb 2022 03:46:46 +0000 (14:46 +1100)
commit2f0f7bd066969b82902cd6488c6b1bbb7a2498e6
treeed45ab3caa8f2ec72e19ca77d02c1a282e635604
parentd5b00c3ca1da448e227997763ae41414913c9096
mm/damon: remove the target id concept

DAMON asks each monitoring target ('struct damon_target') to have one
'unsigned long' integer called 'id', which should be unique among the
targets of same monitoring context.  Meaning of it is, however, totally up
to the monitoring primitives that registered to the monitoring context.
For example, the virtual address spaces monitoring primitives treats the
id as a 'struct pid' pointer.

This makes the code flexible, but ugly, not well-documented, and
type-unsafe[1].  Also, identification of each target can be done via its
index.  For the reason, this commit removes the concept and uses clear
type definition.  For now, only 'struct pid' pointer is used for the
virtual address spaces monitoring.  If DAMON is extended in future so that
we need to put another identifier field in the struct, we will use a union
for such primitives-dependent fields and document which primitives are
using which type.

[1] https://lore.kernel.org/linux-mm/20211013154535.4aaeaaf9d0182922e405dd1e@linux-foundation.org/

Link: https://lkml.kernel.org/r/20211230100723.2238-5-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
include/linux/damon.h
mm/damon/core-test.h
mm/damon/core.c
mm/damon/dbgfs-test.h
mm/damon/dbgfs.c
mm/damon/reclaim.c
mm/damon/vaddr-test.h
mm/damon/vaddr.c