leds: leds-lp50xx: Handle reg to get correct multi_index
authorJohan Adolfsson <johan.adolfsson@axis.com>
Tue, 17 Jun 2025 10:23:54 +0000 (12:23 +0200)
committerLee Jones <lee@kernel.org>
Fri, 27 Jun 2025 12:58:31 +0000 (13:58 +0100)
commit2e84a5e5374232e6f356ce5c079a5658d7e4af2c
treebde08603e59c6265e8aa3db432fcd736336a1636
parent6012ce6b30567aa8ec8dc5b648b7841f9f74ca7c
leds: leds-lp50xx: Handle reg to get correct multi_index

mc_subled used for multi_index needs well defined array indexes,
to guarantee the desired result, use reg for that.

If devicetree child nodes is processed in random or reverse order
you may end up with multi_index "blue green red" instead of the expected
"red green blue".
If user space apps uses multi_index to deduce how to control the leds
they would most likely be broken without this patch if devicetree
processing is reversed (which it appears to be).

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-fuji.dts has reg set
but I don't see how it can have worked without this change.

If reg is not set, an error is returned,
If reg is out of range, an error is returned.
reg within led child nodes starts with 0, to map to the iout in each bank.

Signed-off-by: Johan Adolfsson <johan.adolfsson@axis.com>
Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Link: https://lore.kernel.org/r/20250617-led-fix-v7-1-cdbe8efc88fa@axis.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-lp50xx.c