net: wwan: t7xx: Add __counted_by for struct t7xx_fsm_event and use struct_size()
authorGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 9 Oct 2023 21:46:18 +0000 (15:46 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Oct 2023 09:11:48 +0000 (10:11 +0100)
commit2dd3071892202ccaec3c59afc65c5b88357e73c9
tree2833f49aaa95f8fd98e8b3d6b27aa4731f62196e
parent13266ad9e52e2e51b0f068b0251a1d5c2badae5c
net: wwan: t7xx: Add __counted_by for struct t7xx_fsm_event and use struct_size()

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

While there, use struct_size() helper, instead of the open-coded
version, to calculate the size for the allocation of the whole
flexible structure, including of course, the flexible-array member.

This code was found with the help of Coccinelle, and audited and
fixed manually.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wwan/t7xx/t7xx_state_monitor.c
drivers/net/wwan/t7xx/t7xx_state_monitor.h