block: unfreeze queue if realloc tag set fails during nr_hw_queues update
authorNilay Shroff <nilay@linux.ibm.com>
Mon, 12 May 2025 09:13:38 +0000 (14:43 +0530)
committerJens Axboe <axboe@kernel.dk>
Mon, 12 May 2025 13:14:53 +0000 (07:14 -0600)
commit2d8951aee844b7c6d146e25b5c3eebc1c72aa6ff
treee223c8214d9660c716b7c264b71716176ccd1dca
parent824afb9b04648ea11531fc9047923ec07e7a943d
block: unfreeze queue if realloc tag set fails during nr_hw_queues update

In __blk_mq_update_nr_hw_queues(), the current sequence involves:

1. unregistering sysfs/debugfs attributes
2. freeze the queue
3. reallocating the tag set
4. updating the queue map
5. reallocating hardware contexts
6. updating the elevator (which unfreeze the queue again)
7. re-register sysfs/debugfs attributes

If tag set reallocation fails at step 3, the function skips steps 4–6
and proceeds directly to step 7, re-registering the sysfs/debugfs
attributes without unfreezing the queue first. This is incorrect and
can lead to a system hang or lockdep splat, as the queue remains frozen
and is never properly unfrozen.

This patch addresses the issue by explicitly unfreezing the queue before
re-registering the sysfs/debugfs attributes in the event of a tag set
reallocation failure.

Fixes: 9dc7a882ce96 ("block: move hctx debugfs/sysfs registering out of freezing queue")
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250512092952.135887-1-nilay@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c