drm/i915: use fine grained -Woverride-init disable
authorJani Nikula <jani.nikula@intel.com>
Thu, 28 Mar 2024 10:24:55 +0000 (12:24 +0200)
committerJani Nikula <jani.nikula@intel.com>
Tue, 2 Apr 2024 07:53:59 +0000 (10:53 +0300)
commit2d2d92bc2583cbfbe4d156f5fdf6c49789c94a6f
treed76b25983eee4f8888d2a1e38bc642f10e7a663d
parent5a1da42b50f3594e18738885c2f23ed36629dd00
drm/i915: use fine grained -Woverride-init disable

Use localized __diag_push(), __diag_ignore_all() with rationale, and
__diag_pop() for specific initializations instead of blanket disabling
of -Woverride-init across several files.

Note that we've tried this before with commit 88e9664434c9 ("drm/i915:
use localized __diag_ignore_all() instead of per file") and reverted in
commit 290d16104575 ("Revert "drm/i915: use localized
__diag_ignore_all() instead of per file""). The issue turned out to be
in __diag_ignore_all() and it was fixed by commit 689b097a06ba
("compiler-gcc: Suppress -Wmissing-prototypes warning for all supported
GCC"). So we should be able to pull this off now.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240328102455.944131-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/Makefile
drivers/gpu/drm/i915/display/intel_display_device.c
drivers/gpu/drm/i915/display/intel_fbdev.c
drivers/gpu/drm/i915/i915_pci.c
drivers/gpu/drm/xe/Makefile