USB: sisusbvga: Fix a potential UB casued by left shifting a negative value
authorChangming Liu <charley.ashbringer@gmail.com>
Sat, 11 Jul 2020 04:30:18 +0000 (00:30 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Jul 2020 14:48:10 +0000 (16:48 +0200)
commit2b53a19284f537168fb506f2f40d7fda40a01162
treed8eef43a1976f0773698edf9c26f475b4a7bf40a
parent48025b4f3fa4a599921c1dc231983f41f9eecbc5
USB: sisusbvga: Fix a potential UB casued by left shifting a negative value

The char buffer buf, receives data directly from user space,
so its content might be negative and its elements are left
shifted to form an unsigned integer.

Since left shifting a negative value is undefined behavior, thus
change the char to u8 to elimintate this UB.

Signed-off-by: Changming Liu <charley.ashbringer@gmail.com>
Link: https://lore.kernel.org/r/20200711043018.928-1-charley.ashbringer@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/sisusbvga/sisusb.c