KVM: x86: Open code all direct reads to guest DR6 and DR7
authorSean Christopherson <seanjc@google.com>
Fri, 9 Feb 2024 22:07:52 +0000 (14:07 -0800)
committerSean Christopherson <seanjc@google.com>
Fri, 23 Feb 2024 00:14:47 +0000 (16:14 -0800)
commit2a5f091ce1c9222fc9f98374d92db9539e6004ae
treeca55b97b7852cb1ee2ad57a397aa04c7b32cac5a
parentfc5375dd8c062d81001b50008d65ca09e942f924
KVM: x86: Open code all direct reads to guest DR6 and DR7

Bite the bullet, and open code all direct reads of DR6 and DR7.  KVM
currently has a mix of open coded accesses and calls to kvm_get_dr(),
which is confusing and ugly because there's no rhyme or reason as to why
any particular chunk of code uses kvm_get_dr().

The obvious alternative is to force all accesses through kvm_get_dr(),
but it's not at all clear that doing so would be a net positive, e.g. even
if KVM ends up wanting/needing to force all reads through a common helper,
e.g. to play caching games, the cost of reverting this change is likely
lower than the ongoing cost of maintaining weird, arbitrary code.

No functional change intended.

Cc: Mathias Krause <minipli@grsecurity.net>
Reviewed-by: Mathias Krause <minipli@grsecurity.net>
Link: https://lore.kernel.org/r/20240209220752.388160-3-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/smm.c
arch/x86/kvm/vmx/nested.c
arch/x86/kvm/x86.c