selftest: rtc: Add to check rtc alarm status for alarm related test
authorJoseph Jang <jjang@nvidia.com>
Mon, 21 Oct 2024 03:22:13 +0000 (20:22 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 23 Oct 2024 20:13:00 +0000 (14:13 -0600)
commit2a027d6bb66002c8e50e974676f932b33c5fce10
tree414a8856e6110c780efe51efca951455dd3297c4
parentecfe6870abac400036d802e28dde4822ec153ffd
selftest: rtc: Add to check rtc alarm status for alarm related test

In alarm_wkalm_set and alarm_wkalm_set_minute test, they use different
ioctl (RTC_ALM_SET/RTC_WKALM_SET) for alarm feature detection. They will
skip testing if RTC_ALM_SET/RTC_WKALM_SET ioctl returns an EINVAL error
code. This design may miss detecting real problems when the
efi.set_wakeup_time() return errors and then RTC_ALM_SET/RTC_WKALM_SET
ioctl returns an EINVAL error code with RTC_FEATURE_ALARM enabled.

In order to make rtctest more explicit and robust, we propose to use
RTC_PARAM_GET ioctl interface to check rtc alarm feature state before
running alarm related tests. If the kernel does not support RTC_PARAM_GET
ioctl interface, we will fallback to check the error number of
(RTC_ALM_SET/RTC_WKALM_SET) ioctl call for alarm feature detection.

Requires commit 101ca8d05913b ("rtc: efi: Enable SET/GET WAKEUP services
as optional")

Reviewed-by: Koba Ko <kobak@nvidia.com>
Reviewed-by: Matthew R. Ochs <mochs@nvidia.com>
Signed-off-by: Joseph Jang <jjang@nvidia.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/rtc/Makefile
tools/testing/selftests/rtc/rtctest.c