tps6598x: clear int mask on probe failure
authorJens Axboe <axboe@kernel.dk>
Tue, 15 Feb 2022 18:22:04 +0000 (11:22 -0700)
committerHector Martin <marcan@marcan.st>
Sat, 19 Feb 2022 09:07:45 +0000 (18:07 +0900)
commit28e7602201b671a4b60a00bccff78bb614ee7d23
tree30d925e7c9a8b95604ad44986d7181d7b897a804
parentf9ac316488a07df4777d7351bc74f9c81813308f
tps6598x: clear int mask on probe failure

The interrupt mask is enabled before any potential failure points in
the driver, which can leave a failure path where we exit with
interrupts enabled but the device not live. This causes an infinite
stream of interrupts on an Apple M1 Pro laptop on USB-C.

Add a failure label that's used post enabling interrupts, where we
mask them again before returning an error.

Suggested-by: Sven Peter <sven@svenpeter.dev>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
drivers/usb/typec/tipd/core.c