ALSA: hda: hda_component: Fix mutex crash if nothing ever binds
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Mon, 26 Aug 2024 09:49:40 +0000 (10:49 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 26 Aug 2024 10:03:57 +0000 (12:03 +0200)
commit28b329f431cef840fddd9a9b493bc3eff1aa06c0
tree345482ffdc6f76579e86ff4681a6a523da239e45
parent2dc43c5e212036458ed7c5586fb82ee183fee504
ALSA: hda: hda_component: Fix mutex crash if nothing ever binds

Move the initialization of parent->mutex into
hda_component_manager_init() so that it is always valid.

In hda_component_manager_bind() do not clear the parent information.
Only zero-fill the per-component data ready for it to be filled in
by the components as they bind.

Previously parent->mutex was being initialized only in
hda_component_manager_bind(). This meant that it was only
initialized if all components appeared and there was a bind callback.
If there wasn't a bind the mutex object was not valid when the
Realtek driver called any of the other functions.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 047b9cbbaa8e ("ALSA: hda: hda_component: Protect shared data with a mutex")
Link: https://patch.msgid.link/20240826094940.45563-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_component.c