bnxt_en: Make PTP timestamp HWRM more silent
authorBreno Leitao <leitao@debian.org>
Thu, 25 Jan 2024 13:41:03 +0000 (05:41 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 26 Jan 2024 22:06:21 +0000 (14:06 -0800)
commit281cb9d65a95c00bb844f332cd187491d2d55496
treed8b2078fc66d25bb6be90520da8ecd432e8b0cd9
parentc3dfcdb65ec1a4813ec1e0871c52c671ba9c71ac
bnxt_en: Make PTP timestamp HWRM more silent

commit 056bce63c469 ("bnxt_en: Make PTP TX timestamp HWRM query silent")
changed a netdev_err() to netdev_WARN_ONCE().

netdev_WARN_ONCE() is it generates a kernel WARNING, which is bad, for
the following reasons:

 * You do not a kernel warning if the firmware queries are late
 * In busy networks, timestamp query failures fairly regularly
 * A WARNING message doesn't bring much value, since the code path
is clear.
(This was discussed in-depth in [1])

Transform the netdev_WARN_ONCE() into a netdev_warn_once(), and print a
more well-behaved message, instead of a full WARN().

bnxt_en 0000:67:00.0 eth0: TS query for TX timer failed rc = fffffff5

Link: https://lore.kernel.org/all/ZbDj%2FFI4EJezcfd1@gmail.com/
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Fixes: 056bce63c469 ("bnxt_en: Make PTP TX timestamp HWRM query silent")
Link: https://lore.kernel.org/r/20240125134104.2045573-1-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c