kallsyms: Refactor kallsyms_show_value() to take cred
authorKees Cook <keescook@chromium.org>
Thu, 2 Jul 2020 18:49:23 +0000 (11:49 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Jul 2020 06:13:29 +0000 (08:13 +0200)
commit27801485039d491539d29c262e8927ccff6cf477
tree7570a43f20ec1ba4335beff99d2fd4234b2a7fad
parent2ceb2995e1a6c5c241eedb50a6ac9ac5e305d801
kallsyms: Refactor kallsyms_show_value() to take cred

commit 160251842cd35a75edfb0a1d76afa3eb674ff40a upstream.

In order to perform future tests against the cred saved during open(),
switch kallsyms_show_value() to operate on a cred, and have all current
callers pass current_cred(). This makes it very obvious where callers
are checking the wrong credential in their "read" contexts. These will
be fixed in the coming patches.

Additionally switch return value to bool, since it is always used as a
direct permission check, not a 0-on-success, negative-on-error style
function return.

Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/filter.h
include/linux/kallsyms.h
kernel/kallsyms.c
kernel/kprobes.c
kernel/module.c