stmmac: xsk: fix negative overflow of budget in zerocopy mode
authorJason Xing <kernelxing@tencent.com>
Wed, 23 Jul 2025 14:23:26 +0000 (22:23 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 26 Jul 2025 18:23:08 +0000 (11:23 -0700)
commit2764ab51d5f0e8c7d3b7043af426b1883e3bde1d
treea09806dd0dcf38373c5fd8645594a8b817670c43
parenteccf7a3480a06eb698f064af829733bd8d0ec263
stmmac: xsk: fix negative overflow of budget in zerocopy mode

A negative overflow can happen when the budget number of descs are
consumed. as long as the budget is decreased to zero, it will again go
into while (budget-- > 0) statement and get decreased by one, so the
overflow issue can happen. It will lead to returning true whereas the
expected value should be false.

In this case where all the budget is used up, it means zc function
should return false to let the poll run again because normally we
might have more data to process. Without this patch, zc function would
return true instead.

Fixes: 132c32ee5bc0 ("net: stmmac: Add TX via XDP zero-copy socket")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Link: https://patch.msgid.link/20250723142327.85187-2-kerneljasonxing@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c