arm64: Simplify do_notify_resume() DAIF masking
authorMark Rutland <mark.rutland@arm.com>
Tue, 6 Feb 2024 12:38:46 +0000 (12:38 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Tue, 20 Feb 2024 18:12:13 +0000 (18:12 +0000)
commit270de609ae2af441d15289406340ff209e5dc864
tree8bc18acec0a6e3257f00cc017b04d217276aefb3
parent54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478
arm64: Simplify do_notify_resume() DAIF masking

In do_notify_resume, we handle _TIF_NEED_RESCHED differently from all
other flags, leaving IRQ+FIQ masked when calling into schedule(). This
masking is a historical artifact, and it is not currently necessary
to mask IRQ+FIQ when calling into schedule (as evidenced by the generic
exit_to_user_mode_loop(), which unmasks IRQs before checking
_TIF_NEED_RESCHED and calling schedule()).

This patch removes the special case for _TIF_NEED_RESCHED, moving this
check into the main loop such that schedule() will be called from a
regular process context with IRQ+FIQ unmasked. This is a minor
simplification to do_notify_resume() and brings it into line with the
generic exit_to_user_mode_loop() logic. This will also aid subsequent
rework of DAIF management.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: James Morse <james.morse@arm.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20240206123848.1696480-2-mark.rutland@arm.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Tested-by: Itaru Kitayama <itaru.kitayama@linux.dev>
arch/arm64/kernel/signal.c