Revert "leds: trigger: netdev: Configure LED blink interval for HW offload"
authorDaniel Golle <daniel@makrotopia.org>
Sat, 12 Jul 2025 15:39:21 +0000 (16:39 +0100)
committerLee Jones <lee@kernel.org>
Fri, 18 Jul 2025 13:26:32 +0000 (14:26 +0100)
commit26f732791f2bcab18f59c61915bbe35225f30136
tree75a4638f35ba5350ce7f9b3f0092b828a7c1b927
parent239afba8b9f3b0fcfd464d5ffeaed0ed4441c5a4
Revert "leds: trigger: netdev: Configure LED blink interval for HW offload"

This reverts commit c629c972b310af41e9e072febb6dae9a299edde6.

While .led_blink_set() would previously put an LED into an unconditional
permanently blinking state, the offending commit now uses same operation
to (also?) set the blink timing of the netdev trigger when offloading.

This breaks many if not all of the existing PHY drivers which offer
offloading LED operations, as those drivers would just put the LED into
blinking state after .led_blink_set() has been called.

Unfortunately the change even made it into stable kernels for unknown
reasons, so it should be reverted there as well.

Fixes: c629c972b310a ("leds: trigger: netdev: Configure LED blink interval for HW offload")
Link: https://lore.kernel.org/linux-leds/c6134e26-2e45-4121-aa15-58aaef327201@lunn.ch/T/#m9d6fe81bbcb273e59f12bbedbd633edd32118387
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/6dcc77ee1c9676891d6250d8994850f521426a0f.1752334655.git.daniel@makrotopia.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/trigger/ledtrig-netdev.c