projects / linux-block.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3078d96) | patch
netfilter: nfnetlink_hook: fix check for snprintf() overflow
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 19 Jun 2021 13:55:46 +0000 (16:55 +0300)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 21 Jun 2021 20:05:29 +0000 (22:05 +0200)
commit24610ed80df65a564d6165d15505a950d05f9f5a
tree472932825e271ae415eab1dec306a68f754031f3tree
parent3078d964c0fe6cf8eba197c862d1011cb7c0e7b4commit | diff
netfilter: nfnetlink_hook: fix check for snprintf() overflow

The kernel version of snprintf() can't return negatives.  The
"ret > (int)sizeof(sym)" check is off by one because and it should be
>=.  Finally, we need to set a negative error code.

Fixes: e2cf17d3774c ("netfilter: add new hook nfnl subsystem")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nfnetlink_hook.c diff | blob | blame | history
Linux 6.x block layer and io_uring tree(s)