blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()
authorLi Jinlin <lijinlin3@huawei.com>
Tue, 7 Sep 2021 12:12:42 +0000 (20:12 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 26 Sep 2021 12:09:01 +0000 (14:09 +0200)
commit23dfb959c6cbb8346a5143f44a970373fcb4ce8f
tree64b2100e18cc20296c4495a541e4b514fa068e0c
parenta2551d0a29e937515a9711b604d88cd1a31c386f
blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()

[ Upstream commit 884f0e84f1e3195b801319c8ec3d5774e9bf2710 ]

The pending timer has been set up in blk_throtl_init(). However, the
timer is not deleted in blk_throtl_exit(). This means that the timer
handler may still be running after freeing the timer, which would
result in a use-after-free.

Fix by calling del_timer_sync() to delete the timer in blk_throtl_exit().

Signed-off-by: Li Jinlin <lijinlin3@huawei.com>
Link: https://lore.kernel.org/r/20210907121242.2885564-1-lijinlin3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/blk-throttle.c