virtio_net: fix missing dma unmap for resize
authorXuan Zhuo <xuanzhuo@linux.alibaba.com>
Tue, 26 Dec 2023 09:43:33 +0000 (17:43 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Jan 2024 00:45:02 +0000 (16:45 -0800)
commit2311e06b9bf3d44e15f9175af177a782806f688f
tree7072b1589b3951a7f5841bb2254e19e8fe035e4e
parent01b2885d9415152bcb12ff1f7788f500a74ea0ed
virtio_net: fix missing dma unmap for resize

For rq, we have three cases getting buffers from virtio core:

1. virtqueue_get_buf{,_ctx}
2. virtqueue_detach_unused_buf
3. callback for virtqueue_resize

But in commit 295525e29a5b("virtio_net: merge dma operations when
filling mergeable buffers"), I missed the dma unmap for the #3 case.

That will leak some memory, because I did not release the pages referred
by the unused buffers.

If we do such script, we will make the system OOM.

    while true
    do
            ethtool -G ens4 rx 128
            ethtool -G ens4 rx 256
            free -m
    done

Fixes: 295525e29a5b ("virtio_net: merge dma operations when filling mergeable buffers")
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Link: https://lore.kernel.org/r/20231226094333.47740-1-xuanzhuo@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/virtio_net.c